Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Upgrade grpc, guava, netty, snappy-java, use slim neo4j driver #7057

Merged
merged 2 commits into from
Jun 23, 2023
Merged

3.x: Upgrade grpc, guava, netty, snappy-java, use slim neo4j driver #7057

merged 2 commits into from
Jun 23, 2023

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jun 22, 2023 •
edited
Loading

Dependency upgrades:

  • netty 4.1.94.Final
  • tcnative 2.0.61.Final (test dependency)
  • grpc-java 1.56.0
  • guava 32.0.1
  • snappy-java 1.1.10.1 (fourth party dependency of kafka-client)
  • Switch to use neo4j-java-driver-slim so that we control Netty version

@barchetta barchetta added dependencies Pull requests that update a dependency file 3.x Issues for 3.x version branch labels Jun 22, 2023
@barchetta barchetta added this to the 3.2.2 milestone Jun 22, 2023
@barchetta barchetta self-assigned this Jun 22, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 22, 2023
danielkec
danielkec previously approved these changes Jun 23, 2023
View reviewed changes
thegridman
thegridman requested changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@thegridman thegridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest release of grpc-java is 1.56.0 (which was released on the 14th, last week) so you may as well use that version.

@dalexandrov
Copy link
Contributor

LGTM

@barchetta barchetta merged commit 1ec37f3 into helidon-io:helidon-3.x Jun 23, 2023
@barchetta barchetta deleted the 3.x-owasp branch August 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegridman thegridman thegridman approved these changes

@danielkec danielkec danielkec left review comments

@dalexandrov dalexandrov Awaiting requested review from dalexandrov

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
3.x Issues for 3.x version branch dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
Archived in project
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@barchetta @dalexandrov @danielkec @thegridman